From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2 1/2] r8169: fix RTL8111EVL EEE and green settings Date: Sun, 19 Nov 2017 21:33:45 +0900 (KST) Message-ID: <20171119.213345.268615734786365623.davem@davemloft.net> References: <684cde92-a961-6221-6d59-113cd488ea98@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: nic_swsd@realtek.com, hau@realtek.com, netdev@vger.kernel.org To: hkallweit1@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:52936 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750822AbdKSMdu (ORCPT ); Sun, 19 Nov 2017 07:33:50 -0500 In-Reply-To: <684cde92-a961-6221-6d59-113cd488ea98@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Sun, 19 Nov 2017 11:09:58 +0100 > Name of functions rtl_w0w1_eri and rtl_w0w1_phy is somewhat misleading > regarding order of arguments. One could assume that w0w1 means > argument with bits to be reset comes before argument with bits to set. > However this is not the case. > So fix the order of arguments in several statements. > > In addition fix EEE advertisement. The current code resets the bits > for 100BaseT and 1000BaseT EEE advertisement what is not what we want. > > I have a little of a hard time to find a proper "Fixes" line as the > issue seems to have been there forever (at least it existed already > when the driver was moved to the current place in 2011). > > The patch was tested on a Zotac Mini-PC with a RTL8111E-VL chip. > Before the patch EEE was disabled, now it's properly advertised and > works fine. > > Signed-off-by: Heiner Kallweit Applied.