From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH net-next 1/1] net: dsa: microchip: Add Microchip KSZ8895 DSA driver Date: Mon, 20 Nov 2017 11:56:09 +0100 Message-ID: <20171120105609.GA4460@amd> References: <1510886597-5666-1-git-send-email-Tristram.Ha@microchip.com> <1510886597-5666-2-git-send-email-Tristram.Ha@microchip.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WIyZ46R2i8wDzkSu" Cc: Andrew Lunn , Florian Fainelli , muvarov@gmail.com, nathan.leigh.conrad@gmail.com, vivien.didelot@savoirfairelinux.com, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org To: Tristram.Ha@microchip.com Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:40683 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbdKTK4L (ORCPT ); Mon, 20 Nov 2017 05:56:11 -0500 Content-Disposition: inline In-Reply-To: <1510886597-5666-2-git-send-email-Tristram.Ha@microchip.com> Sender: netdev-owner@vger.kernel.org List-ID: --WIyZ46R2i8wDzkSu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Tristram Ha >=20 > Add Microchip KSZ8895 DSA driver. >=20 > Signed-off-by: Tristram Ha > Reviewed-by: Woojung Huh Thanks for patches. I installed whole series on top of net-next. Hardware is: root@miro:~# cat /proc/cpuinfo model name : ARM926EJ-S rev 5 (v5l) Hardware : Freescale MXS (Device Tree) I added devicetree chunks, and enabled DSA in the config. It seems switch is detected: [ 4.775934] Micrel KSZ8051 dsa-0.0:00: attached PHY driver [Micrel KSZ8051] (mii_bus:phy_addr=3Ddsa-0.0:00, irq=3DPOLL) [ 4.885952] Micrel KSZ8051 dsa-0.0:01: attached PHY driver [Micrel KSZ8051] (mii_bus:phy_addr=3Ddsa-0.0:01, irq=3DPOLL) [ 4.995934] Micrel KSZ8051 dsa-0.0:02: attached PHY driver [Micrel KSZ8051] (mii_bus:phy_addr=3Ddsa-0.0:02, irq=3DPOLL) [ 5.011484] DSA: tree 0 setup root@miro:~# ifconfig lan3 192.168.20.103 netmask 255.255.0.0 up [ 131.196667] IPv6: ADDRCONF(NETDEV_UP): lan3: link is not ready root@miro:~# [ 132.225863] ksz8895-switch spi2.0 lan3: Link is Up - 100Mbps/Full - flow control rx/tx [ 132.233939] IPv6: ADDRCONF(NETDEV_CHANGE): lan3: link becomes ready root@miro:~# ping 192.168.1.1 PING 192.168.1.1 (192.168.1.1): 56 data bytes ^C --- 192.168.1.1 ping statistics --- 7 packets transmitted, 0 packets received, 100% packet loss root@miro:~# ifconfig [ 149.904234] random: crng init done But packets do not go through, and there is nothing helpful in dmesg. Dts part is: spi@0 { compatible =3D "microchip,ksz8895"; spi-max-frequency =3D <25000000>; reg =3D <0>; // reset-gpios =3D <&gpio2 8 0>; status =3D "okay"; spi-cpha; spi-cpol; ports { #address-cells =3D <1>; #size-cells =3D <0>; port@0 { reg =3D <0>; label =3D "lan1"; }; port@1 { reg =3D <1>; label =3D "lan2"; }; port@2 { reg =3D <2>; label =3D "lan3"; }; port@4 { reg =3D <4>; label =3D "cpu"; ethernet =3D <&mac0>; fixed-link { speed =3D <100>; full-duplex; }; }; }; }; I went back to my version of dsa patches, and test above works as expected. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --WIyZ46R2i8wDzkSu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAloStMkACgkQMOfwapXb+vKSdACeORHBEAyP3BiBE8c+zzSKDRVZ BMoAn0v2kl3foUWpxuCByxlVX8NMyVOr =+doA -----END PGP SIGNATURE----- --WIyZ46R2i8wDzkSu--