From: Florian Westphal <fw@strlen.de>
To: David Ahern <dsahern@gmail.com>
Cc: Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org
Subject: Re: JOIN_ANYCAST breakage w. "net: ipv6: put host and anycast routes on device with address"
Date: Mon, 20 Nov 2017 12:56:06 +0100 [thread overview]
Message-ID: <20171120115606.GA24866@breakpoint.cc> (raw)
In-Reply-To: <9c34433f-c6ae-3881-4995-f0f840078d8d@gmail.com>
David Ahern <dsahern@gmail.com> wrote:
> On 11/14/17 10:36 AM, Florian Westphal wrote:
> > Hi David
> >
> > This test program no longer works with 4.14
> > (recvfrom: Resource temporarily unavailable)
> >
> > after reverting commit
> > 4832c30d5458387ff2533ff66fbde26ad8bb5a2d
> > (net: ipv6: put host and anycast routes on device with address)
> >
> > it will work again ("OK").
> >
> > Could you please have a look at this?
> >
>
> This restores the previous behavior:
>
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index 05eb7bc36156..1c29d9bcedc3 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -1019,7 +1019,7 @@ static struct net_device
> *ip6_rt_get_dev_rcu(struct rt6_info *rt)
> {
> struct net_device *dev = rt->dst.dev;
>
> - if (rt->rt6i_flags & RTF_LOCAL) {
> + if (rt->rt6i_flags & (RTF_LOCAL | RTF_ANYCAST)) {
> /* for copies of local routes, dst->dev needs to be the
> * device if it is a master device, the master device if
> * device is enslaved, and the loopback as the default
Looks like it, thanks David!
prev parent reply other threads:[~2017-11-20 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 17:36 JOIN_ANYCAST breakage w. "net: ipv6: put host and anycast routes on device with address" Florian Westphal
2017-11-15 15:57 ` David Ahern
2017-11-18 0:09 ` David Ahern
2017-11-20 11:56 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120115606.GA24866@breakpoint.cc \
--to=fw@strlen.de \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).