From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: JOIN_ANYCAST breakage w. "net: ipv6: put host and anycast routes on device with address" Date: Mon, 20 Nov 2017 12:56:06 +0100 Message-ID: <20171120115606.GA24866@breakpoint.cc> References: <20171114173616.GA24842@breakpoint.cc> <9c34433f-c6ae-3881-4995-f0f840078d8d@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Florian Westphal , netdev@vger.kernel.org To: David Ahern Return-path: Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:46190 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbdKTL5D (ORCPT ); Mon, 20 Nov 2017 06:57:03 -0500 Content-Disposition: inline In-Reply-To: <9c34433f-c6ae-3881-4995-f0f840078d8d@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: David Ahern wrote: > On 11/14/17 10:36 AM, Florian Westphal wrote: > > Hi David > > > > This test program no longer works with 4.14 > > (recvfrom: Resource temporarily unavailable) > > > > after reverting commit > > 4832c30d5458387ff2533ff66fbde26ad8bb5a2d > > (net: ipv6: put host and anycast routes on device with address) > > > > it will work again ("OK"). > > > > Could you please have a look at this? > > > > This restores the previous behavior: > > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index 05eb7bc36156..1c29d9bcedc3 100644 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c > @@ -1019,7 +1019,7 @@ static struct net_device > *ip6_rt_get_dev_rcu(struct rt6_info *rt) > { > struct net_device *dev = rt->dst.dev; > > - if (rt->rt6i_flags & RTF_LOCAL) { > + if (rt->rt6i_flags & (RTF_LOCAL | RTF_ANYCAST)) { > /* for copies of local routes, dst->dev needs to be the > * device if it is a master device, the master device if > * device is enslaved, and the loopback as the default Looks like it, thanks David!