From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH net 05/10] net: xdp: don't allow device-bound programs in driver mode Date: Mon, 20 Nov 2017 14:02:11 -0800 Message-ID: <20171120140211.2c59595b@cakuba.netronome.com> References: <20171120045522.2188-1-jakub.kicinski@netronome.com> <20171120045522.2188-6-jakub.kicinski@netronome.com> <0ca26b61-3c92-5bc1-a6ef-2deb8025c41c@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, alexei.starovoitov@gmail.com, daniel@iogearbox.net To: David Ahern Return-path: Received: from mail-pg0-f66.google.com ([74.125.83.66]:38793 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbdKTWEM (ORCPT ); Mon, 20 Nov 2017 17:04:12 -0500 Received: by mail-pg0-f66.google.com with SMTP id s11so8474225pgc.5 for ; Mon, 20 Nov 2017 14:04:12 -0800 (PST) In-Reply-To: <0ca26b61-3c92-5bc1-a6ef-2deb8025c41c@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 20 Nov 2017 07:36:39 -0700, David Ahern wrote: > On 11/19/17 9:55 PM, Jakub Kicinski wrote: > > diff --git a/net/core/dev.c b/net/core/dev.c > > index 09525a27319c..21de2d37a0ba 100644 > > --- a/net/core/dev.c > > +++ b/net/core/dev.c > > @@ -7143,6 +7143,13 @@ int dev_change_xdp_fd(struct net_device *dev, struct netlink_ext_ack *extack, > > bpf_op == ops->ndo_bpf); > > if (IS_ERR(prog)) > > return PTR_ERR(prog); > > + > > + if (!(flags & XDP_FLAGS_HW_MODE) && > > + bpf_prog_is_dev_bound(prog->aux)) { > > + NL_SET_ERR_MSG_MOD(extack, "using device-bound program without HW_MODE flag not supported"); > > I don't see dev_change_xdp_fd called by device drivers, so that should > just be NL_SET_ERR_MSG. Also, "is not supported" sounds better to me > than just "not supported". Thanks, I'll give others a couple more hours and respin!