From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, idosch@mellanox.com, mlxsw@mellanox.com
Subject: Re: [patch net] mlxsw: spectrum: Do not try to create non-existing ports during unsplit
Date: Tue, 21 Nov 2017 20:15:51 +0900 (KST) [thread overview]
Message-ID: <20171121.201551.50423381159309300.davem@davemloft.net> (raw)
In-Reply-To: <20171121084221.6338-1-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 21 Nov 2017 09:42:21 +0100
> From: Ido Schimmel <idosch@mellanox.com>
>
> On some systems, when we unsplit a port we need to re-create two ports
> instead. On other systems, only one needs to be re-created.
>
> Do not try to create a port if during driver initialization it was
> assigned a negative module number, which is invalid.
>
> This avoids the following error during unsplit:
> [ 941.012478] mlxsw_spectrum 0000:01:00.0: Port 43: Failed to map module
>
> The error is harmless and caused by the fact that a local port is
> already mapped to module 0.
>
> Fixes: be94535f9531 ("mlxsw: spectrum: Make split flow match firmware requirements")
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Reviewed-by: Arkadi Sharshevsky <arkadis@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Applied.
prev parent reply other threads:[~2017-11-21 11:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 8:42 [patch net] mlxsw: spectrum: Do not try to create non-existing ports during unsplit Jiri Pirko
2017-11-21 11:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121.201551.50423381159309300.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).