From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch net] mlxsw: spectrum: Do not try to create non-existing ports during unsplit Date: Tue, 21 Nov 2017 20:15:51 +0900 (KST) Message-ID: <20171121.201551.50423381159309300.davem@davemloft.net> References: <20171121084221.6338-1-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, idosch@mellanox.com, mlxsw@mellanox.com To: jiri@resnulli.us Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:54322 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751570AbdKULQn (ORCPT ); Tue, 21 Nov 2017 06:16:43 -0500 In-Reply-To: <20171121084221.6338-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: From: Jiri Pirko Date: Tue, 21 Nov 2017 09:42:21 +0100 > From: Ido Schimmel > > On some systems, when we unsplit a port we need to re-create two ports > instead. On other systems, only one needs to be re-created. > > Do not try to create a port if during driver initialization it was > assigned a negative module number, which is invalid. > > This avoids the following error during unsplit: > [ 941.012478] mlxsw_spectrum 0000:01:00.0: Port 43: Failed to map module > > The error is harmless and caused by the fact that a local port is > already mapped to module 0. > > Fixes: be94535f9531 ("mlxsw: spectrum: Make split flow match firmware requirements") > Signed-off-by: Ido Schimmel > Reviewed-by: Arkadi Sharshevsky > Signed-off-by: Jiri Pirko Applied.