From: David Miller <davem@davemloft.net>
To: jon.maloy@ericsson.com
Cc: netdev@vger.kernel.org,
mohan.krishna.ghanta.krishnamurthy@ericsson.com,
tung.q.nguyen@dektech.com.au, hoang.h.le@dektech.com.au,
canh.d.luu@dektech.com.au, ying.xue@windriver.com,
tipc-discussion@lists.sourceforge.net
Subject: Re: [net 1/1] tipc: fix access of released memory
Date: Tue, 21 Nov 2017 20:22:29 +0900 (KST) [thread overview]
Message-ID: <20171121.202229.341348187080505844.davem@davemloft.net> (raw)
In-Reply-To: <1511210583-26135-1-git-send-email-jon.maloy@ericsson.com>
From: Jon Maloy <jon.maloy@ericsson.com>
Date: Mon, 20 Nov 2017 21:43:03 +0100
> When the function tipc_group_filter_msg() finds that a member event
> indicates that the member is leaving the group, it first deletes the
> member instance, and then purges the message queue being handled
> by the call. But the message queue is an aggregated field in the
> just deleted item, leading the purge call to access freed memory.
>
> We fix this by swapping the order of the two actions.
>
> Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Applied, thanks Jon.
prev parent reply other threads:[~2017-11-21 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 20:43 [net 1/1] tipc: fix access of released memory Jon Maloy
2017-11-21 11:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121.202229.341348187080505844.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=canh.d.luu@dektech.com.au \
--cc=hoang.h.le@dektech.com.au \
--cc=jon.maloy@ericsson.com \
--cc=mohan.krishna.ghanta.krishnamurthy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=tung.q.nguyen@dektech.com.au \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).