From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [net 1/1] tipc: fix access of released memory Date: Tue, 21 Nov 2017 20:22:29 +0900 (KST) Message-ID: <20171121.202229.341348187080505844.davem@davemloft.net> References: <1511210583-26135-1-git-send-email-jon.maloy@ericsson.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, mohan.krishna.ghanta.krishnamurthy@ericsson.com, tung.q.nguyen@dektech.com.au, hoang.h.le@dektech.com.au, canh.d.luu@dektech.com.au, ying.xue@windriver.com, tipc-discussion@lists.sourceforge.net To: jon.maloy@ericsson.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:54388 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751669AbdKULWh (ORCPT ); Tue, 21 Nov 2017 06:22:37 -0500 In-Reply-To: <1511210583-26135-1-git-send-email-jon.maloy@ericsson.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jon Maloy Date: Mon, 20 Nov 2017 21:43:03 +0100 > When the function tipc_group_filter_msg() finds that a member event > indicates that the member is leaving the group, it first deletes the > member instance, and then purges the message queue being handled > by the call. But the message queue is an aggregated field in the > just deleted item, leading the purge call to access freed memory. > > We fix this by swapping the order of the two actions. > > Signed-off-by: Jon Maloy Applied, thanks Jon.