From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: nic_swsd@realtek.com, Chun-Hao Lin <hau@realtek.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] r8169: fix RTL8111EVL EEE and green settings
Date: Tue, 21 Nov 2017 02:34:16 +0100 [thread overview]
Message-ID: <20171121013416.GA15896@lunn.ch> (raw)
In-Reply-To: <684cde92-a961-6221-6d59-113cd488ea98@gmail.com>
Hi Heiner
Do you have access to the data sheet?
I had a quick look through the driver. It would be nice to refactor it
to follow the usual Linux conventions:
Turn the MDIO read/write functions into an MDIO bus driver.
Move the PHY code into drivers/net/phy/realtek.c, and in the process,
replace all the magic numbers with #defines.
Do you have any interest in doing this?
Andrew
next prev parent reply other threads:[~2017-11-21 1:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-19 10:09 [PATCH v2 1/2] r8169: fix RTL8111EVL EEE and green settings Heiner Kallweit
2017-11-19 10:15 ` [PATCH v2 2/2] r8169: use same RTL8111EVL green settings as in vendor driver Heiner Kallweit
2017-11-19 12:33 ` David Miller
2017-11-19 12:33 ` [PATCH v2 1/2] r8169: fix RTL8111EVL EEE and green settings David Miller
2017-11-21 1:34 ` Andrew Lunn [this message]
2017-11-21 6:45 ` Heiner Kallweit
2017-12-16 17:11 ` Heiner Kallweit
2017-12-16 18:03 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121013416.GA15896@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hau@realtek.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).