From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v2 1/2] r8169: fix RTL8111EVL EEE and green settings
Date: Tue, 21 Nov 2017 02:34:16 +0100
Message-ID: <20171121013416.GA15896@lunn.ch>
References: <684cde92-a961-6221-6d59-113cd488ea98@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: nic_swsd@realtek.com, Chun-Hao Lin <hau@realtek.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:60493 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751389AbdKUBeZ (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 20 Nov 2017 20:34:25 -0500
Content-Disposition: inline
In-Reply-To: <684cde92-a961-6221-6d59-113cd488ea98@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi Heiner

Do you have access to the data sheet?

I had a quick look through the driver. It would be nice to refactor it
to follow the usual Linux conventions:

Turn the MDIO read/write functions into an MDIO bus driver.

Move the PHY code into drivers/net/phy/realtek.c, and in the process,
replace all the magic numbers with #defines.

Do you have any interest in doing this?

   Andrew