From: Andrew Lunn <andrew@lunn.ch>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org, tremyfr@gmail.com,
davem@davemloft.net
Subject: Re: [RESEND PATCH] net: realtek: r8169: implement set_link_ksettings()
Date: Tue, 21 Nov 2017 19:21:32 +0100 [thread overview]
Message-ID: <20171121182132.GC30040@lunn.ch> (raw)
In-Reply-To: <20171121151557.4573-1-tjakobi@math.uni-bielefeld.de>
On Tue, Nov 21, 2017 at 04:15:57PM +0100, Tobias Jakobi wrote:
> Commit 6fa1ba61520576cf1346c4ff09a056f2950cb3bf partially
> implemented the new ethtool API, by replacing get_settings()
> with get_link_ksettings(). This breaks ethtool, since the
> userspace tool (according to the new API specs) never tries
> the legacy set() call, when the new get() call succeeds.
>
> All attempts to chance some setting from userspace result in:
> > Cannot set new settings: Operation not supported
>
> Implement the missing set() call.
>
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Fixes: 6fa1ba615205 ("net: realtek: r8169: use new api ethtool_{get|set}_link_ksettings")
It would be good to have this in stable.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2017-11-21 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 15:15 [RESEND PATCH] net: realtek: r8169: implement set_link_ksettings() Tobias Jakobi
2017-11-21 18:06 ` Holger Hoffstätte
2017-11-21 18:21 ` Andrew Lunn [this message]
2017-11-23 16:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121182132.GC30040@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=tjakobi@math.uni-bielefeld.de \
--cc=tremyfr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).