From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [RESEND PATCH] net: realtek: r8169: implement set_link_ksettings() Date: Tue, 21 Nov 2017 19:21:32 +0100 Message-ID: <20171121182132.GC30040@lunn.ch> References: <20171121151557.4573-1-tjakobi@math.uni-bielefeld.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: nic_swsd@realtek.com, netdev@vger.kernel.org, tremyfr@gmail.com, davem@davemloft.net To: Tobias Jakobi Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:60902 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751184AbdKUSVk (ORCPT ); Tue, 21 Nov 2017 13:21:40 -0500 Content-Disposition: inline In-Reply-To: <20171121151557.4573-1-tjakobi@math.uni-bielefeld.de> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Nov 21, 2017 at 04:15:57PM +0100, Tobias Jakobi wrote: > Commit 6fa1ba61520576cf1346c4ff09a056f2950cb3bf partially > implemented the new ethtool API, by replacing get_settings() > with get_link_ksettings(). This breaks ethtool, since the > userspace tool (according to the new API specs) never tries > the legacy set() call, when the new get() call succeeds. > > All attempts to chance some setting from userspace result in: > > Cannot set new settings: Operation not supported > > Implement the missing set() call. > > Signed-off-by: Tobias Jakobi Fixes: 6fa1ba615205 ("net: realtek: r8169: use new api ethtool_{get|set}_link_ksettings") It would be good to have this in stable. Reviewed-by: Andrew Lunn Andrew