From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: [PATCH iproute2/master] bpf: initialize the verifier log Date: Wed, 22 Nov 2017 17:00:53 -0800 Message-ID: <20171123010053.2398-1-jakub.kicinski@netronome.com> Cc: oss-drivers@netronome.com, daniel@iogearbox.net, Jakub Kicinski To: netdev@vger.kernel.org Return-path: Received: from mail-pl0-f67.google.com ([209.85.160.67]:39729 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751549AbdKWBBJ (ORCPT ); Wed, 22 Nov 2017 20:01:09 -0500 Received: by mail-pl0-f67.google.com with SMTP id l16so1730400pli.6 for ; Wed, 22 Nov 2017 17:01:09 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: If program loading fails before verifier prints its first message, the verifier log will not be initialized. Always set the first character of the log buffer to zero to make sure we don't dump non-printable characters to the terminal. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- lib/bpf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/bpf.c b/lib/bpf.c index 10ea23a471ef..fdc28772fb71 100644 --- a/lib/bpf.c +++ b/lib/bpf.c @@ -1153,7 +1153,7 @@ static int bpf_log_realloc(struct bpf_elf_ctx *ctx) { const size_t log_max = UINT_MAX >> 8; size_t log_size = ctx->log_size; - void *ptr; + char *ptr; if (!ctx->log) { log_size = 65536; @@ -1169,6 +1169,7 @@ static int bpf_log_realloc(struct bpf_elf_ctx *ctx) if (!ptr) return -ENOMEM; + ptr[0] = 0; ctx->log = ptr; ctx->log_size = log_size; -- 2.14.1