netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 1/1] actions: Add support for user cookies
Date: Thu, 23 Nov 2017 13:09:30 -0800	[thread overview]
Message-ID: <20171123130930.6efd6291@xeon-e3> (raw)
In-Reply-To: <1492864583-20892-1-git-send-email-jhs@emojatatu.com>

On Sat, 22 Apr 2017 08:36:23 -0400
Jamal Hadi Salim <jhs@mojatatu.com> wrote:

> +
> +			if (*argv && strcmp(*argv, "cookie") == 0) {
> +				size_t slen;
> +
> +				NEXT_ARG();
> +				slen = strlen(*argv);
> +				if (slen > TC_COOKIE_MAX_SIZE * 2) {
> +					char cookie_err_m[128];
> +
> +					snprintf(cookie_err_m, 128,
> +						 "%zd Max allowed size %d",
> +						 slen, TC_COOKIE_MAX_SIZE*2);
> +					invarg(cookie_err_m, *argv);

Don't bother going to effort of building a string for invarg(). Instead either
just print invalid cookie or use fprintf.

Also, what if kernel limits change? 

  parent reply	other threads:[~2017-11-23 21:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-22 12:36 [PATCH iproute2 1/1] actions: Add support for user cookies Jamal Hadi Salim
2017-04-23 16:11 ` Stephen Hemminger
2017-04-23 17:18   ` Jamal Hadi Salim
2017-11-23 16:36 ` Jiri Pirko
2017-11-23 17:32   ` Jamal Hadi Salim
2017-11-23 17:55     ` Jiri Pirko
2017-11-23 21:09 ` Stephen Hemminger [this message]
2017-11-23 21:12 ` Stephen Hemminger
  -- strict thread matches above, loose matches on Subject: below --
2017-03-21 20:35 Jamal Hadi Salim
2017-03-21 21:22 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171123130930.6efd6291@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).