From: Stefano Brivio <sbrivio@redhat.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Eric Garver <e@erig.me>,
Pravin B Shelar <pshelar@ovn.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net] geneve: only configure or fill UDP_ZERO_CSUM6_RX/TX info when CONFIG_IPV6
Date: Thu, 23 Nov 2017 13:35:26 +0100 [thread overview]
Message-ID: <20171123133526.393b5aa5@elisabeth> (raw)
In-Reply-To: <1511407644-27357-1-git-send-email-liuhangbin@gmail.com>
On Thu, 23 Nov 2017 11:27:24 +0800
Hangbin Liu <liuhangbin@gmail.com> wrote:
> Stefano pointed that configure or show UDP_ZERO_CSUM6_RX/TX info doesn't
> make sense if we haven't enabled CONFIG_IPV6. Fix it by adding
> if IS_ENABLED(CONFIG_IPV6) check.
Thanks for fixing this. I would add:
Suggested-by: Stefano Brivio <sbrivio@redhat.com>
Fixes: abe492b4f50c ("geneve: UDP checksum configuration via netlink")
Fixes: fd7eafd02121 ("geneve: fix fill_info when link down")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
next prev parent reply other threads:[~2017-11-23 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 3:27 [PATCH net] geneve: only configure or fill UDP_ZERO_CSUM6_RX/TX info when CONFIG_IPV6 Hangbin Liu
2017-11-23 12:35 ` Stefano Brivio [this message]
2017-11-23 13:01 ` Hangbin Liu
2017-11-23 18:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123133526.393b5aa5@elisabeth \
--to=sbrivio@redhat.com \
--cc=davem@davemloft.net \
--cc=e@erig.me \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).