From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio Subject: Re: [PATCH net] geneve: only configure or fill UDP_ZERO_CSUM6_RX/TX info when CONFIG_IPV6 Date: Thu, 23 Nov 2017 13:35:26 +0100 Message-ID: <20171123133526.393b5aa5@elisabeth> References: <1511407644-27357-1-git-send-email-liuhangbin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Eric Garver , Pravin B Shelar , "David S. Miller" To: Hangbin Liu Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59616 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751729AbdKWMfe (ORCPT ); Thu, 23 Nov 2017 07:35:34 -0500 In-Reply-To: <1511407644-27357-1-git-send-email-liuhangbin@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 23 Nov 2017 11:27:24 +0800 Hangbin Liu wrote: > Stefano pointed that configure or show UDP_ZERO_CSUM6_RX/TX info doesn't > make sense if we haven't enabled CONFIG_IPV6. Fix it by adding > if IS_ENABLED(CONFIG_IPV6) check. Thanks for fixing this. I would add: Suggested-by: Stefano Brivio Fixes: abe492b4f50c ("geneve: UDP checksum configuration via netlink") Fixes: fd7eafd02121 ("geneve: fix fill_info when link down") > Signed-off-by: Hangbin Liu Reviewed-by: Stefano Brivio -- Stefano