From: Jiri Pirko <jiri@resnulli.us>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 1/1] actions: Add support for user cookies
Date: Thu, 23 Nov 2017 17:36:12 +0100 [thread overview]
Message-ID: <20171123163612.GA2040@nanopsycho> (raw)
In-Reply-To: <1492864583-20892-1-git-send-email-jhs@emojatatu.com>
Sat, Apr 22, 2017 at 02:36:23PM CEST, jhs@mojatatu.com wrote:
[...]
>@@ -274,8 +302,17 @@ tc_print_one_action(FILE *f, struct rtattr *arg)
> return err;
>
> if (show_stats && tb[TCA_ACT_STATS]) {
>+
> fprintf(f, "\tAction statistics:\n");
> print_tcstats2_attr(f, tb[TCA_ACT_STATS], "\t", NULL);
>+ if (tb[TCA_ACT_COOKIE]) {
>+ int strsz = RTA_PAYLOAD(tb[TCA_ACT_COOKIE]);
>+ char b1[strsz+1];
>+
>+ fprintf(f, "\n\tcookie len %d %s ", strsz,
>+ hexstring_n2a(RTA_DATA(tb[TCA_ACT_COOKIE]),
>+ strsz, b1, sizeof(b1)));
>+ }
Jamal, is there any particular reason that you print cookie only in case
you show stats? What is the relation between cookie and stats?
> fprintf(f, "\n");
> }
>
>--
>1.9.1
>
next prev parent reply other threads:[~2017-11-23 16:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-22 12:36 [PATCH iproute2 1/1] actions: Add support for user cookies Jamal Hadi Salim
2017-04-23 16:11 ` Stephen Hemminger
2017-04-23 17:18 ` Jamal Hadi Salim
2017-11-23 16:36 ` Jiri Pirko [this message]
2017-11-23 17:32 ` Jamal Hadi Salim
2017-11-23 17:55 ` Jiri Pirko
2017-11-23 21:09 ` Stephen Hemminger
2017-11-23 21:12 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2017-03-21 20:35 Jamal Hadi Salim
2017-03-21 21:22 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123163612.GA2040@nanopsycho \
--to=jiri@resnulli.us \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).