From: David Miller <davem@davemloft.net>
To: idosch@mellanox.com
Cc: netdev@vger.kernel.org, dsahern@gmail.com, andy@greyhouse.net,
mlxsw@mellanox.com
Subject: Re: [PATCH net] ipv6: Do not consider linkdown nexthops during multipath
Date: Fri, 24 Nov 2017 01:27:23 +0900 (KST) [thread overview]
Message-ID: <20171124.012723.1606817313489376114.davem@davemloft.net> (raw)
In-Reply-To: <20171121075012.11077-1-idosch@mellanox.com>
From: Ido Schimmel <idosch@mellanox.com>
Date: Tue, 21 Nov 2017 09:50:12 +0200
> When the 'ignore_routes_with_linkdown' sysctl is set, we should not
> consider linkdown nexthops during route lookup.
>
> While the code correctly verifies that the initially selected route
> ('match') has a carrier, it does not perform the same check in the
> subsequent multipath selection, resulting in a potential packet loss.
>
> In case the chosen route does not have a carrier and the sysctl is set,
> choose the initially selected route.
>
> Fixes: 35103d11173b ("net: ipv6 sysctl option to ignore routes when nexthop link is down")
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Applied.
prev parent reply other threads:[~2017-11-23 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 7:50 [PATCH net] ipv6: Do not consider linkdown nexthops during multipath Ido Schimmel
2017-11-21 19:00 ` David Ahern
2017-11-21 19:11 ` Andy Gospodarek
2017-11-23 16:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171124.012723.1606817313489376114.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=dsahern@gmail.com \
--cc=idosch@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).