From: David Miller <davem@davemloft.net>
To: tjakobi@math.uni-bielefeld.de
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org, tremyfr@gmail.com
Subject: Re: [RESEND PATCH] net: realtek: r8169: implement set_link_ksettings()
Date: Fri, 24 Nov 2017 01:37:09 +0900 (KST) [thread overview]
Message-ID: <20171124.013709.1115845967707059385.davem@davemloft.net> (raw)
In-Reply-To: <20171121151557.4573-1-tjakobi@math.uni-bielefeld.de>
From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Date: Tue, 21 Nov 2017 16:15:57 +0100
> Commit 6fa1ba61520576cf1346c4ff09a056f2950cb3bf partially
> implemented the new ethtool API, by replacing get_settings()
> with get_link_ksettings(). This breaks ethtool, since the
> userspace tool (according to the new API specs) never tries
> the legacy set() call, when the new get() call succeeds.
>
> All attempts to chance some setting from userspace result in:
>> Cannot set new settings: Operation not supported
>
> Implement the missing set() call.
>
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Applied and queued up for -stable, thanks!
prev parent reply other threads:[~2017-11-23 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 15:15 [RESEND PATCH] net: realtek: r8169: implement set_link_ksettings() Tobias Jakobi
2017-11-21 18:06 ` Holger Hoffstätte
2017-11-21 18:21 ` Andrew Lunn
2017-11-23 16:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171124.013709.1115845967707059385.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=tjakobi@math.uni-bielefeld.de \
--cc=tremyfr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).