From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [RESEND PATCH] net: realtek: r8169: implement
 set_link_ksettings()
Date: Fri, 24 Nov 2017 01:37:09 +0900 (KST)
Message-ID: <20171124.013709.1115845967707059385.davem@davemloft.net>
References: <20171121151557.4573-1-tjakobi@math.uni-bielefeld.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org, tremyfr@gmail.com
To: tjakobi@math.uni-bielefeld.de
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:44362 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752945AbdKWQhL (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 23 Nov 2017 11:37:11 -0500
In-Reply-To: <20171121151557.4573-1-tjakobi@math.uni-bielefeld.de>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Date: Tue, 21 Nov 2017 16:15:57 +0100

> Commit 6fa1ba61520576cf1346c4ff09a056f2950cb3bf partially
> implemented the new ethtool API, by replacing get_settings()
> with get_link_ksettings(). This breaks ethtool, since the
> userspace tool (according to the new API specs) never tries
> the legacy set() call, when the new get() call succeeds.
> 
> All attempts to chance some setting from userspace result in:
>> Cannot set new settings: Operation not supported
> 
> Implement the missing set() call.
> 
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>

Applied and queued up for -stable, thanks!