Re: [RFC net-next 4/6] netdevsim: add software driver for testing offloads

[Jiri Pirko <jiri@resnulli.us>]

Fri, Nov 24, 2017 at 08:49:17AM CET, jakub.kicinski@netronome.com wrote:
>On Thu, Nov 23, 2017 at 11:24 PM, Jiri Pirko <jiri@resnulli.us> wrote:
>> Fri, Nov 24, 2017 at 03:36:11AM CET, jakub.kicinski@netronome.com wrote:
>>>To be able to run selftests without any hardware required we
>>>need a software model.  The model can also serve as an example
>>>implementation for those implementing actual HW offloads.
>>>The dummy driver have previously been extended to test SR-IOV,
>>>but the general consensus seems to be against adding further
>>>features to it.
>>>
>>>Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
>>>Reviewed-by: Simon Horman <simon.horman@netronome.com>
>>>---
>>
>> [...]
>>
>>
>>>+++ b/drivers/net/netdevsim/netdev.c
>>>@@ -0,0 +1,136 @@
>>>+/*
>>>+ * Copyright (C) 2017 Netronome Systems, Inc.
>>>+ *
>>>+ * This software is dual licensed under the GNU General License Version 2,
>>>+ * June 1991 as shown in the file COPYING in the top-level directory of this
>>>+ * source tree or the BSD 2-Clause License provided below.  You have the
>>>+ * option to license this software under the complete terms of either license.
>>>+ *
>>>+ * The BSD 2-Clause License:
>>
>> Why gpl2 is not enough for this?
>
>It's the license I got from legal, I will request permission to use
>pure gpl2.  Thanks!

Yeah, I semi-understand need for bsd for actual hw driver (we have it
for mlxsw as well). But for this testing driver, it really does not make
sense.