From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [RFC net-next 4/6] netdevsim: add software driver for testing offloads Date: Fri, 24 Nov 2017 09:07:17 +0100 Message-ID: <20171124080717.GC3384@nanopsycho> References: <20171124023613.16855-1-jakub.kicinski@netronome.com> <20171124023613.16855-5-jakub.kicinski@netronome.com> <20171124072410.GA3384@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux Netdev List , oss-drivers@netronome.com, Daniel Borkmann , Alexei Starovoitov To: Jakub Kicinski Return-path: Received: from mail-wm0-f44.google.com ([74.125.82.44]:35246 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751631AbdKXIHT (ORCPT ); Fri, 24 Nov 2017 03:07:19 -0500 Received: by mail-wm0-f44.google.com with SMTP id y80so20717236wmd.0 for ; Fri, 24 Nov 2017 00:07:18 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Fri, Nov 24, 2017 at 08:49:17AM CET, jakub.kicinski@netronome.com wrote: >On Thu, Nov 23, 2017 at 11:24 PM, Jiri Pirko wrote: >> Fri, Nov 24, 2017 at 03:36:11AM CET, jakub.kicinski@netronome.com wrote: >>>To be able to run selftests without any hardware required we >>>need a software model. The model can also serve as an example >>>implementation for those implementing actual HW offloads. >>>The dummy driver have previously been extended to test SR-IOV, >>>but the general consensus seems to be against adding further >>>features to it. >>> >>>Signed-off-by: Jakub Kicinski >>>Reviewed-by: Simon Horman >>>--- >> >> [...] >> >> >>>+++ b/drivers/net/netdevsim/netdev.c >>>@@ -0,0 +1,136 @@ >>>+/* >>>+ * Copyright (C) 2017 Netronome Systems, Inc. >>>+ * >>>+ * This software is dual licensed under the GNU General License Version 2, >>>+ * June 1991 as shown in the file COPYING in the top-level directory of this >>>+ * source tree or the BSD 2-Clause License provided below. You have the >>>+ * option to license this software under the complete terms of either license. >>>+ * >>>+ * The BSD 2-Clause License: >> >> Why gpl2 is not enough for this? > >It's the license I got from legal, I will request permission to use >pure gpl2. Thanks! Yeah, I semi-understand need for bsd for actual hw driver (we have it for mlxsw as well). But for this testing driver, it really does not make sense.