From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [patch iproute2 00/11] tc: jsonify couple of qdics, filter and
 actions
Date: Sun, 26 Nov 2017 22:26:12 +0100
Message-ID: <20171126212612.GA1965@nanopsycho.orion>
References: <20171125144835.5045-1-jiri@resnulli.us>
 <20171126124417.6f97f325@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, jhs@mojatatu.com, mlxsw@mellanox.com
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr0-f180.google.com ([209.85.128.180]:45651 "EHLO
        mail-wr0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751766AbdKZV0P (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 26 Nov 2017 16:26:15 -0500
Received: by mail-wr0-f180.google.com with SMTP id a63so24597802wrc.12
        for <netdev@vger.kernel.org>; Sun, 26 Nov 2017 13:26:14 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20171126124417.6f97f325@xeon-e3>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Sun, Nov 26, 2017 at 09:44:17PM CET, stephen@networkplumber.org wrote:
>On Sat, 25 Nov 2017 15:48:24 +0100
>Jiri Pirko <jiri@resnulli.us> wrote:
>
>> From: Jiri Pirko <jiri@mellanox.com>
>> 
>> An example json output:
>> 
>> $ tc -s -j filter show dev ens8 egress
>> [{
>>         "protocol": "ip",
>>         "pref": 6001,
>>         "kind": "flower",
>>         "chain": 0
>>     },{
>>         "protocol": "ip",
>>         "pref": 6001,
>>         "kind": "flower",
>>         "chain": 0,
>>         "options": {
>>             "handle": 1,
>>             "keys": {
>>                 "eth_type": "ipv4",
>>                 "dst_ip": "192.168.250.1"
>>             },
>>             "not_in_hw": true,
>>             "actions": [{
>>                     "order": 1,
>>                     "kind": "gact",
>>                     "control_action": {
>>                         "type": "drop"
>>                     },
>>                     "prob": {
>>                         "random_type": "none",
>>                         "control_action": {
>>                             "type": "pass"
>>                         },
>>                         "val": 0
>>                     },
>>                     "index": 1,
>>                     "ref": 1,
>>                     "bind": 1,
>>                     "installed": 1667830,
>>                     "last_used": 1667830,
>>                     "stats": {
>>                         "bytes": 0,
>>                         "packets": 0,
>>                         "drops": 0,
>>                         "overlimits": 0,
>>                         "requeues": 0,
>>                         "backlog": 0,
>>                         "qlen": 0,
>>                         "requeues": 0
>>                     },
>>                     "cookie": "a1b2c3d4aaaaaaaabb"
>>                 }
>>             }
>>         }
>>     }
>> ]
>> $ tc -s filter show dev ens8 egress
>> filter pref 6001 flower chain 0 
>> filter pref 6001 flower chain 0 handle 0x1 
>>   eth_type ipv4
>>   dst_ip 192.168.250.1
>>   not_in_hw
>>         action order 1: gact action drop
>>          random type none pass val 0
>>          index 1 ref 1 bind 1 installed 16689 sec used 16689 sec
>>         Action statistics:
>>         Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0) 
>>         backlog 0b 0p requeues 0
>>         cookie a1b2c3d4aaaaaaaabb
>> 
>> ---
>> To be applied on top of my cookie fix patchset
>> 
>> Jiri Pirko (11):
>>   tc: jsonify qdisc core
>>   tc: jsonify stats2
>>   tc: jsonify fq_codel qdisc
>>   tc: jsonify htb qdisc
>>   tc: jsonify filter core
>>   tc: jsonify flower filter
>>   tc: jsonify matchall filter
>>   tc: jsonify actions core
>>   tc: jsonify gact action
>>   tc: jsonify mirred action
>>   tc: jsonify vlan action
>> 
>>  tc/f_flower.c   | 287 +++++++++++++++++++++++++++++++++-----------------------
>>  tc/f_matchall.c |  12 +--
>>  tc/m_action.c   |  22 +++--
>>  tc/m_gact.c     |  18 ++--
>>  tc/m_mirred.c   |  46 +++++++--
>>  tc/m_vlan.c     |  26 +++--
>>  tc/q_fq_codel.c |  25 +++--
>>  tc/q_htb.c      |  20 ++--
>>  tc/tc.c         |   5 +-
>>  tc/tc_filter.c  |  47 ++++++----
>>  tc/tc_qdisc.c   |  52 ++++++----
>>  tc/tc_util.c    |  66 +++++++++----
>>  tc/tc_util.h    |   1 +
>>  13 files changed, 396 insertions(+), 231 deletions(-)
>> 
>
>
>Applied, but other qdisc need some jsonification as well.

and classes/actions. I agree.