From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [RFC net-next 4/6] netdevsim: add software driver for testing offloads Date: Mon, 27 Nov 2017 11:42:49 -0800 Message-ID: <20171127114249.111b1825@cakuba.netronome.com> References: <20171124023613.16855-1-jakub.kicinski@netronome.com> <20171124023613.16855-5-jakub.kicinski@netronome.com> <20171128.043026.1559245605707710598.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, daniel@iogearbox.net, alexei.starovoitov@gmail.com, jiri@resnulli.us, Sabrina Dubroca , Phil Sutter To: David Miller Return-path: Received: from mail-pl0-f44.google.com ([209.85.160.44]:42995 "EHLO mail-pl0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbdK0Tmw (ORCPT ); Mon, 27 Nov 2017 14:42:52 -0500 Received: by mail-pl0-f44.google.com with SMTP id z3so9102598plh.9 for ; Mon, 27 Nov 2017 11:42:52 -0800 (PST) In-Reply-To: <20171128.043026.1559245605707710598.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 28 Nov 2017 04:30:26 +0900 (KST), David Miller wrote: > From: Jakub Kicinski > Date: Thu, 23 Nov 2017 18:36:11 -0800 > > > The dummy driver have previously been extended to test SR-IOV, > > but the general consensus seems to be against adding further > > features to it. > > I guess this is fine, but then is it going to be the case that > every time we want to add a software offload implementation for > testing driver paths we add yet another dummy driver? I would expect others to extend the netdevsim driver, so all test/SW implementation would live there. I was considering moving the SR-IOV code over, too, but I'm worried I will break existing tests. Phil, Sabrina would you be OK with that?