From: Stephen Hemminger <stephen@networkplumber.org>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: netdev@vger.kernel.org, jiri@mellanox.com
Subject: Re: [PATCH iproute2] tc: police: fix control action parsing
Date: Mon, 27 Nov 2017 12:32:59 -0800 [thread overview]
Message-ID: <20171127123259.324f20cf@xeon-e3> (raw)
In-Reply-To: <01774dea3239d1127d2e174a48419db4089c4de3.1511805077.git.mprivozn@redhat.com>
On Mon, 27 Nov 2017 19:00:14 +0100
Michal Privoznik <mprivozn@redhat.com> wrote:
> parse_action_control helper does advancing of the arg inside. So don't
> do it outside.
>
> Fixes: e67aba559581 ("tc: actions: add helpers to parse and print control actions")
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
The helpers are not helping here.
Adding another layer of indirection on moving argc/argv then causing caller
to have to keep track is bad design.
Also since pars_action_control_slash is only used by police, why was it
moved into tc_util in the first place? I would prefer just to rip out that
bit and put it back in policer.
next prev parent reply other threads:[~2017-11-27 20:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 17:51 [PATCH] tc: police: fix control action parsing Michal Privoznik
2017-11-27 20:32 ` Stephen Hemminger [this message]
2017-11-28 12:57 ` [PATCH iproute2] " Michal Privoznik
2017-11-28 13:02 ` Jiri Pirko
2017-11-29 9:06 ` Michal Privoznik
2017-12-06 17:55 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127123259.324f20cf@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=jiri@mellanox.com \
--cc=mprivozn@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).