From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [PATCH net 3/5] sctp: only allow the asoc reset when the asoc outq is empty Date: Mon, 27 Nov 2017 11:36:50 -0200 Message-ID: <20171127133650.GJ3473@localhost.localdomain> References: <49b01e67e4cc1f8a0be85ffefdee51dad6ae3286.1511614961.git.lucien.xin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: network dev , linux-sctp@vger.kernel.org, davem@davemloft.net, Neil Horman To: Xin Long Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39476 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752305AbdK0Ngx (ORCPT ); Mon, 27 Nov 2017 08:36:53 -0500 Content-Disposition: inline In-Reply-To: <49b01e67e4cc1f8a0be85ffefdee51dad6ae3286.1511614961.git.lucien.xin@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, Nov 25, 2017 at 09:05:34PM +0800, Xin Long wrote: > As it says in rfc6525#section5.1.4, before sending the request, > > C2: The sender has either no outstanding TSNs or considers all > outstanding TSNs abandoned. > > Prior to this patch, it tried to consider all outstanding TSNs abandoned > by dropping all chunks in all outqs with sctp_outq_free (even including > sacked, retransmit and transmitted queues) when doing this reset, which > is too aggressive. > > To make it work gently, this patch will only allow the asoc reset when > the sender has no outstanding TSNs by checking if unsent, transmitted > and retransmit are all empty with sctp_outq_is_empty before sending > and processing the request. > > Fixes: 692787cef651 ("sctp: implement receiver-side procedures for the SSN/TSN Reset Request Parameter") > Signed-off-by: Xin Long Acked-by: Marcelo Ricardo Leitner > --- > net/sctp/stream.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/net/sctp/stream.c b/net/sctp/stream.c > index b209037..f3b7d27 100644 > --- a/net/sctp/stream.c > +++ b/net/sctp/stream.c > @@ -406,6 +406,9 @@ int sctp_send_reset_assoc(struct sctp_association *asoc) > if (asoc->strreset_outstanding) > return -EINPROGRESS; > > + if (!sctp_outq_is_empty(&asoc->outqueue)) > + return -EAGAIN; > + > chunk = sctp_make_strreset_tsnreq(asoc); > if (!chunk) > return -ENOMEM; > @@ -728,6 +731,12 @@ struct sctp_chunk *sctp_process_strreset_tsnreq( > } > goto err; > } > + > + if (!sctp_outq_is_empty(&asoc->outqueue)) { > + result = SCTP_STRRESET_IN_PROGRESS; > + goto err; > + } > + > asoc->strreset_inseq++; > > if (!(asoc->strreset_enable & SCTP_ENABLE_RESET_ASSOC_REQ)) > -- > 2.1.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sctp" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >