[PATCH RESEND] net: phy: harmonize phy_id{,_mask} data type

[PATCH RESEND] net: phy: harmonize phy_id{,_mask} data type

[Richard Leitner]

From: Richard Leitner <richard.leitner@skidata.com>

Previously phy_id was u32 and phy_id_mask was unsigned int. As the
phy_id_mask defines the important bits of the phy_id (and is therefore
the same size) these two variables should be the same data type.

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
RESEND as suggested by Andrew Lunn
---
 include/linux/phy.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/phy.h b/include/linux/phy.h
index dc82a07cb4fd..e00fd9ce3bce 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -509,7 +509,7 @@ struct phy_driver {
 	struct mdio_driver_common mdiodrv;
 	u32 phy_id;
 	char *name;
-	unsigned int phy_id_mask;
+	u32 phy_id_mask;
 	u32 features;
 	u32 flags;
 	const void *driver_data;
-- 
2.11.0

Re: [PATCH RESEND] net: phy: harmonize phy_id{,_mask} data type

[Andrew Lunn]

On Mon, Nov 27, 2017 at 08:16:45AM +0100, Richard Leitner wrote:
> From: Richard Leitner <richard.leitner@skidata.com>
> 
> Previously phy_id was u32 and phy_id_mask was unsigned int. As the
> phy_id_mask defines the important bits of the phy_id (and is therefore
> the same size) these two variables should be the same data type.

Hi Richard

It is normal to put inside the [] of the subject line which of the two
trees this patch is for. In this case net-next.

No need to resend, but please try to do this for your the next
networking patch.

	   Andrew

Re: [PATCH RESEND] net: phy: harmonize phy_id{,_mask} data type

[Richard Leitner]

On 11/27/2017 02:50 PM, Andrew Lunn wrote:
> On Mon, Nov 27, 2017 at 08:16:45AM +0100, Richard Leitner wrote:
>> From: Richard Leitner <richard.leitner@skidata.com>
>>
>> Previously phy_id was u32 and phy_id_mask was unsigned int. As the
>> phy_id_mask defines the important bits of the phy_id (and is therefore
>> the same size) these two variables should be the same data type.
> 
> Hi Richard
> 
> It is normal to put inside the [] of the subject line which of the two
> trees this patch is for. In this case net-next.
> 
> No need to resend, but please try to do this for your the next
> networking patch.

Ok. Thank you for the information. Just saw that it's described in
netdev-FAQ.txt. Sorry for not reading that in advance!

> 
> 	   Andrew
> 

Re: [PATCH RESEND] net: phy: harmonize phy_id{,_mask} data type

[David Miller]

From: Richard Leitner <dev@g0hl1n.net>
Date: Mon, 27 Nov 2017 08:16:45 +0100

> From: Richard Leitner <richard.leitner@skidata.com>
> 
> Previously phy_id was u32 and phy_id_mask was unsigned int. As the
> phy_id_mask defines the important bits of the phy_id (and is therefore
> the same size) these two variables should be the same data type.
> 
> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Applied.