From: Solio Sarabia <solio.sarabia@intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: kys@microsoft.com, shiny.sebastian@intel.com, dsahern@gmail.com,
davem@davemloft.net, stephen@networkplumber.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net-sysfs: export gso_max_size attribute
Date: Mon, 27 Nov 2017 13:47:39 -0800 [thread overview]
Message-ID: <20171127214739.GA203@intel.com> (raw)
In-Reply-To: <1511548369.16595.4.camel@gmail.com>
On Fri, Nov 24, 2017 at 10:32:49AM -0800, Eric Dumazet wrote:
> On Fri, 2017-11-24 at 10:14 -0700, David Ahern wrote:
> >
> > This should be added to rtnetlink rather than sysfs.
>
> This is already exposed by rtnetlink [1]
>
> Please lets not add yet another net-sysfs knob.
>
> [1] c70ce028e834f8e51306217dbdbd441d851c64d3 net/rtnetlink: add IFLA_GSO_MAX_SEGS and IFLA_GSO_MAX_SIZE attributes
It's useful `ip -d a` reports these values. Thanks.
I had an old version (iproute2-ss151103). Based on changelog, it is
available since iproute2-ss161009.
prev parent reply other threads:[~2017-11-27 21:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 0:30 [PATCH] net-sysfs: export gso_max_size attribute Solio Sarabia
2017-11-23 21:48 ` Solio Sarabia
2017-11-24 5:18 ` Stephen Hemminger
2017-11-24 17:14 ` David Ahern
2017-11-24 18:32 ` Eric Dumazet
2017-11-24 18:43 ` David Ahern
2017-11-24 18:52 ` Eric Dumazet
2017-11-27 21:47 ` Solio Sarabia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127214739.GA203@intel.com \
--to=solio.sarabia@intel.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shiny.sebastian@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).