From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm: lanai: use %p to format kernel addresses instead of %x
Date: Tue, 28 Nov 2017 16:03:39 -0500 (EST) [thread overview]
Message-ID: <20171128.160339.37744043841577511.davem@davemloft.net> (raw)
In-Reply-To: <20171127133932.11207-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Mon, 27 Nov 2017 13:39:32 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't use %x and casting to print out a kernel address, instead use %p
> and remove the casting. Cleans up smatch warnings:
>
> drivers/atm/lanai.c:1589 service_buffer_allocate() warn: argument 2 to
> %08lX specifier is cast from pointer
> drivers/atm/lanai.c:2221 lanai_dev_open() warn: argument 4 to %lx
> specifier is cast from pointer
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
prev parent reply other threads:[~2017-11-28 21:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 13:39 [PATCH] atm: lanai: use %p to format kernel addresses instead of %x Colin King
2017-11-28 21:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128.160339.37744043841577511.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=3chas3@gmail.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).