From: Andrew Lunn <andrew@lunn.ch>
To: Yangbo Lu <yangbo.lu@nxp.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Shaohui Xie <Shaohui.Xie@nxp.com>
Subject: Re: [PATCH] net: gianfar: add ethtool eee support
Date: Tue, 28 Nov 2017 14:15:51 +0100 [thread overview]
Message-ID: <20171128131551.GA20797@lunn.ch> (raw)
In-Reply-To: <20171128062901.22210-1-yangbo.lu@nxp.com>
On Tue, Nov 28, 2017 at 02:29:01PM +0800, Yangbo Lu wrote:
> From: Shaohui Xie <Shaohui.Xie@nxp.com>
>
> Gianfar does not support EEE, but it can connect to a PHY which supports
> EEE and the PHY advertises EEE by default, and its link partner also
> advertises EEE, so the PHY enters low power mode when traffic rate is low,
> which causes packet loss if an application's traffic rate is low. This
> patch provides .get_eee and .set_eee so that to disable the EEE
> advertisement via ethtool if needed, other EEE features are not supported.
Hi Yangbo
This patch is good, as far as it goes. However, as you said, some PHYs
advertise EEE by default. So i think it would be good to add a call to
phy_ethtool_set_eee() to disable advertisement, e.g. in init_phy().
Thanks
Andrew
next prev parent reply other threads:[~2017-11-28 13:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 6:29 [PATCH] net: gianfar: add ethtool eee support Yangbo Lu
2017-11-28 13:15 ` Andrew Lunn [this message]
2017-12-07 16:44 ` [PATCH net] gianfar: Disable EEE autoneg by default Claudiu Manoil
2017-12-07 17:54 ` Andrew Lunn
2017-12-08 18:23 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2016-12-08 11:27 [PATCH] net: gianfar: add ethtool eee support Shaohui Xie
2016-12-08 23:19 ` David Miller
2016-12-08 23:22 ` Florian Fainelli
2016-12-09 2:55 ` S.H. Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128131551.GA20797@lunn.ch \
--to=andrew@lunn.ch \
--cc=Shaohui.Xie@nxp.com \
--cc=claudiu.manoil@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).