From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Sutter Subject: [iproute PATCH] link_gre6: Detect invalid encaplimit values Date: Tue, 28 Nov 2017 16:49:58 +0100 Message-ID: <20171128154958.18403-1-phil@nwl.cc> Cc: netdev@vger.kernel.org To: Stephen Hemminger Return-path: Received: from orbyte.nwl.cc ([151.80.46.58]:46082 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753937AbdK1PuK (ORCPT ); Tue, 28 Nov 2017 10:50:10 -0500 Sender: netdev-owner@vger.kernel.org List-ID: Looks like a typo: get_u8() returns 0 on success and -1 on error, so the error checking here was ineffective. Fixes: a11b7b71a6eba ("link_gre6: really support encaplimit option") Signed-off-by: Phil Sutter --- ip/link_gre6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/link_gre6.c b/ip/link_gre6.c index 50c1b804ceca7..0a82eaecf2cdd 100644 --- a/ip/link_gre6.c +++ b/ip/link_gre6.c @@ -372,7 +372,7 @@ get_failed: } else { __u8 uval; - if (get_u8(&uval, *argv, 0) < -1) + if (get_u8(&uval, *argv, 0)) invarg("invalid ELIM", *argv); encap_limit = uval; flags &= ~IP6_TNL_F_IGN_ENCAP_LIMIT; -- 2.13.1