From: David Miller <davem@davemloft.net>
To: skhare@vmware.com
Cc: pv-drivers@vmware.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] vmxnet3: increase default rx ring sizes
Date: Wed, 29 Nov 2017 09:14:48 -0500 (EST) [thread overview]
Message-ID: <20171129.091448.2012623126704239343.davem@davemloft.net> (raw)
In-Reply-To: <20171128211204.12234-1-skhare@vmware.com>
From: Shrikrishna Khare <skhare@vmware.com>
Date: Tue, 28 Nov 2017 13:12:04 -0800
> We often notice rx packet drops due to small default rx ring sizes and
> solve the problem by increasing the ring sizes. This patch increases the
> default rx ring sizes thereby reducing the probability of rx packet
> drops out of the box.
>
> Signed-off-by: Shrikrishna Khare <skhare@vmware.com>
> Acked-by: Jin Heo <heoj@vmware.com>
> Acked-by: Guolin Yang <gyang@vmware.com>
> Acked-by: Boon Ang <bang@vmware.com>
That's not enough for me.
If you're going to quadruple your default RX ring size I want to
hear more about the research you did into the packet drops and
whether other things can be done to solve the problem.
Is something holding onto the packets unnecessarily long?
Is something blocking interrupts (hardware or software)?
Is an offload miscoded or misbehaving?
Is there a problem with the RX ring replenish algorithm of the
driver or it's heuristics?
Tell me more about that than just "bumping the RX ring
size fixes the problem".
Thank you.
next prev parent reply other threads:[~2017-11-29 14:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 21:12 [PATCH net-next] vmxnet3: increase default rx ring sizes Shrikrishna Khare
2017-11-28 21:33 ` Andrew Lunn
2017-11-28 21:49 ` Shrikrishna Khare
2017-11-29 14:14 ` David Miller [this message]
[not found] ` <CY4PR05MB30610B7258175B4EE661EDD6A53B0@CY4PR05MB3061.namprd05.prod.outlook.com>
2017-11-30 15:11 ` [Pv-drivers] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129.091448.2012623126704239343.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=skhare@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).