From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: f.fainelli@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] net: phy: core: use genphy version of callbacks read_status and config_aneg per default
Date: Wed, 29 Nov 2017 15:59:34 -0500 (EST) [thread overview]
Message-ID: <20171129.155934.95792978399291254.davem@davemloft.net> (raw)
In-Reply-To: <8aab2425-9738-f54c-dd57-2cf38236ae3f@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Wed, 29 Nov 2017 21:47:16 +0100
> Am 15.11.2017 um 22:56 schrieb Florian Fainelli:
>> On 11/15/2017 01:42 PM, Heiner Kallweit wrote:
>>> read_status and config_aneg are the only mandatory callbacks and most
>>> of the time the generic implementation is used by drivers.
>>> So make the core fall back to the generic version if a driver doesn't
>>> implement the respective callback.
>>>
>>> Also currently the core doesn't seem to verify that drivers implement
>>> the mandatory calls. If a driver doesn't do so we'd just get a NPE.
>>
>> Right, which is not an unusual way to signal that something is mandatory.
>>
>>> With this patch this potential issue doesn't exit any longer.
>>>
>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>
>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>>
>> Note that net-next is closed at the moment, so you will have to resubmit
>> this when the tree opens back again.
>>
> I see that the two patches have status "deferred" in patchwork.
> So do I have to actually resubmit or are they going to be be picked up
> from patchwork?
You must resubmit when the net-next tree opens back up.
prev parent reply other threads:[~2017-11-29 20:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 21:42 [PATCH 1/2] net: phy: core: use genphy version of callbacks read_status and config_aneg per default Heiner Kallweit
2017-11-15 21:45 ` [PATCH 2/2] net: phy: remove generic settings for callbacks config_aneg and read_status from drivers Heiner Kallweit
2017-11-15 21:58 ` Florian Fainelli
2017-11-15 21:56 ` [PATCH 1/2] net: phy: core: use genphy version of callbacks read_status and config_aneg per default Florian Fainelli
2017-11-29 20:47 ` Heiner Kallweit
2017-11-29 20:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129.155934.95792978399291254.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).