From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 1/2] net: phy: core: use genphy version of callbacks read_status and config_aneg per default Date: Wed, 29 Nov 2017 15:59:34 -0500 (EST) Message-ID: <20171129.155934.95792978399291254.davem@davemloft.net> References: <1b1e4842-690c-95a7-0d07-d596ce97bba5@gmail.com> <8aab2425-9738-f54c-dd57-2cf38236ae3f@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: f.fainelli@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org To: hkallweit1@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:35606 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752118AbdK2U7h (ORCPT ); Wed, 29 Nov 2017 15:59:37 -0500 In-Reply-To: <8aab2425-9738-f54c-dd57-2cf38236ae3f@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Wed, 29 Nov 2017 21:47:16 +0100 > Am 15.11.2017 um 22:56 schrieb Florian Fainelli: >> On 11/15/2017 01:42 PM, Heiner Kallweit wrote: >>> read_status and config_aneg are the only mandatory callbacks and most >>> of the time the generic implementation is used by drivers. >>> So make the core fall back to the generic version if a driver doesn't >>> implement the respective callback. >>> >>> Also currently the core doesn't seem to verify that drivers implement >>> the mandatory calls. If a driver doesn't do so we'd just get a NPE. >> >> Right, which is not an unusual way to signal that something is mandatory. >> >>> With this patch this potential issue doesn't exit any longer. >>> >>> Signed-off-by: Heiner Kallweit >> >> Reviewed-by: Florian Fainelli >> >> Note that net-next is closed at the moment, so you will have to resubmit >> this when the tree opens back again. >> > I see that the two patches have status "deferred" in patchwork. > So do I have to actually resubmit or are they going to be be picked up > from patchwork? You must resubmit when the net-next tree opens back up.