Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: netdev@vger.kernel.org
Cc: oss-drivers@netronome.com, Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: [PATCH net 0/6] tools: bpftool: fix a minor issues with JSON and Makefiles
Date: Tue, 28 Nov 2017 17:44:27 -0800	[thread overview]
Message-ID: <20171129014434.31694-1-jakub.kicinski@netronome.com> (raw)

Quentin says:

First commit in this series fixes a crash that occurs when incorrect
arguments are passed to bpftool after the `--json` option. It comes from
the usage() function trying to use the JSON writer, although the latter
has not been created yet at that point.

Other patches add destruction of the writer in case the program exits in
usage(), fix error messages handling when an unrecognized option is
encountered, remove a spurious new-line character in an error message.

Last patches are related to the Makefiles. They fix the installation
directory prefix and .PHONY targets.

Quentin Monnet (6):
  tools: bpftool: fix crash on bad parameters with JSON
  tools: bpftool: clean up the JSON writer before exiting in usage()
  tools: bpftool: make error message from getopt_long() JSON-friendly
  tools: bpftool: remove spurious line break from error message
  tools: bpftool: change installation directory
  tools: bpftool: declare phony targets as such

 tools/bpf/bpftool/Documentation/Makefile |  2 +-
 tools/bpf/bpftool/Makefile               |  7 ++++---
 tools/bpf/bpftool/main.c                 | 36 +++++++++++++++++++++-----------
 tools/bpf/bpftool/main.h                 |  5 +++--
 4 files changed, 32 insertions(+), 18 deletions(-)

-- 
2.14.1

             reply	other threads:[~2017-11-29  1:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29  1:44 Jakub Kicinski [this message]
2017-11-29  1:44 ` [PATCH net 1/6] tools: bpftool: fix crash on bad parameters with JSON Jakub Kicinski
2017-11-29  1:44 ` [PATCH net 2/6] tools: bpftool: clean up the JSON writer before exiting in usage() Jakub Kicinski
2017-11-29  1:44 ` [PATCH net 3/6] tools: bpftool: make error message from getopt_long() JSON-friendly Jakub Kicinski
2017-11-29  1:44 ` [PATCH net 4/6] tools: bpftool: remove spurious line break from error message Jakub Kicinski
2017-11-29  1:44 ` [PATCH net 5/6] tools: bpftool: unify installation directories Jakub Kicinski
2017-11-29  1:44 ` [PATCH net 6/6] tools: bpftool: declare phony targets as such Jakub Kicinski
2017-11-30  1:17 ` [PATCH net 0/6] tools: bpftool: fix a minor issues with JSON and Makefiles Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171129014434.31694-1-jakub.kicinski@netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox