From: Matthew Wilcox <willy@infradead.org>
To: willy@infradead.org, netdev@vger.kernel.org
Cc: Matthew Wilcox <mawilcox@microsoft.com>
Subject: [PATCH v2 03/17] idr test suite: Fix ida_test_random()
Date: Wed, 29 Nov 2017 12:19:08 -0800 [thread overview]
Message-ID: <20171129201922.24370-4-willy@infradead.org> (raw)
In-Reply-To: <20171129201922.24370-1-willy@infradead.org>
From: Matthew Wilcox <mawilcox@microsoft.com>
The test was checking the wrong errno; ida_get_new_above() returns
EAGAIN, not ENOMEM on memory allocation failure. Double the number of
threads to increase the chance that we actually exercise this path
during the test suite (it was a bit sporadic before).
Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
---
tools/testing/radix-tree/idr-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/radix-tree/idr-test.c b/tools/testing/radix-tree/idr-test.c
index 30cd0b296f1a..193450b29bf0 100644
--- a/tools/testing/radix-tree/idr-test.c
+++ b/tools/testing/radix-tree/idr-test.c
@@ -380,7 +380,7 @@ void ida_check_random(void)
do {
ida_pre_get(&ida, GFP_KERNEL);
err = ida_get_new_above(&ida, bit, &id);
- } while (err == -ENOMEM);
+ } while (err == -EAGAIN);
assert(!err);
assert(id == bit);
}
@@ -489,7 +489,7 @@ static void *ida_random_fn(void *arg)
void ida_thread_tests(void)
{
- pthread_t threads[10];
+ pthread_t threads[20];
int i;
for (i = 0; i < ARRAY_SIZE(threads); i++)
--
2.15.0
next prev parent reply other threads:[~2017-11-29 20:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 20:19 [PATCH v2 00/17] IDR changes for v4.15-rc1 Matthew Wilcox
2017-11-29 20:19 ` [PATCH v2 01/17] idr: Fix build Matthew Wilcox
2017-11-29 20:19 ` [PATCH v2 02/17] radix tree test suite: Remove ARRAY_SIZE Matthew Wilcox
2017-11-29 20:19 ` Matthew Wilcox [this message]
2017-11-29 20:19 ` [PATCH v2 04/17] IDR test suite: Check handling negative end correctly Matthew Wilcox
2017-11-29 20:19 ` [PATCH v2 05/17] idr: Delete idr_remove_ext function Matthew Wilcox
2017-11-29 20:19 ` [PATCH v2 06/17] idr: Delete idr_replace_ext function Matthew Wilcox
2017-11-29 20:19 ` [PATCH v2 07/17] idr: Delete idr_find_ext function Matthew Wilcox
2017-11-29 20:19 ` [PATCH v2 08/17] idr: Add idr_alloc_u32 helper Matthew Wilcox
2017-11-29 20:19 ` [PATCH v2 09/17] net sched actions: Convert to use idr_alloc_u32 Matthew Wilcox
2017-11-29 20:19 ` [PATCH v2 10/17] cls_basic: " Matthew Wilcox
2017-11-29 20:19 ` [PATCH v2 11/17] cls_bpf: " Matthew Wilcox
2017-11-29 20:19 ` [PATCH v2 12/17] cls_flower: Convert to idr_alloc_u32 Matthew Wilcox
2017-11-29 20:19 ` [PATCH v2 13/17] cls_u32: Reinstate cyclic allocation Matthew Wilcox
2017-11-29 20:19 ` [PATCH v2 14/17] cls_u32: Convert to idr_alloc_u32 Matthew Wilcox
2017-11-29 20:19 ` [PATCH v2 15/17] idr: Rename idr_alloc_ext to idr_alloc_ul Matthew Wilcox
2017-11-29 20:19 ` [PATCH v2 16/17] idr: Rename idr_for_each_entry_ext Matthew Wilcox
2017-11-29 20:19 ` [PATCH v2 17/17] idr: Warn if old iterators see large IDs Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129201922.24370-4-willy@infradead.org \
--to=willy@infradead.org \
--cc=mawilcox@microsoft.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).