From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: mvpp2: allocate zeroed tx descriptors Date: Thu, 30 Nov 2017 09:14:45 -0500 (EST) Message-ID: <20171130.091445.264658652404276361.davem@davemloft.net> References: <20171130094946.26647-1-antoine.tenart@free-electrons.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: ymarkman@marvell.com, gregory.clement@free-electrons.com, thomas.petazzoni@free-electrons.com, miquel.raynal@free-electrons.com, nadavh@marvell.com, mw@semihalf.com, stefanc@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: antoine.tenart@free-electrons.com Return-path: In-Reply-To: <20171130094946.26647-1-antoine.tenart@free-electrons.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Antoine Tenart Date: Thu, 30 Nov 2017 10:49:46 +0100 > From: Yan Markman > > Reserved and unused fields in the Tx descriptors should be 0. The PPv2 > driver doesn't clear them at run-time (for performance reasons) but > these descriptors aren't zeroed when allocated, which can lead to > unpredictable behaviors. This patch fixes this by using > dma_zalloc_coherent instead of dma_alloc_coherent. > > Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit") > Signed-off-by: Yan Markman > [Antoine: commit message] > Signed-off-by: Antoine Tenart Applied, thank you.