* [PATCH net] net: mvpp2: allocate zeroed tx descriptors
@ 2017-11-30 9:49 Antoine Tenart
2017-11-30 14:14 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Antoine Tenart @ 2017-11-30 9:49 UTC (permalink / raw)
To: davem
Cc: Yan Markman, gregory.clement, thomas.petazzoni, miquel.raynal,
nadavh, mw, stefanc, netdev, linux-kernel, Antoine Tenart
From: Yan Markman <ymarkman@marvell.com>
Reserved and unused fields in the Tx descriptors should be 0. The PPv2
driver doesn't clear them at run-time (for performance reasons) but
these descriptors aren't zeroed when allocated, which can lead to
unpredictable behaviors. This patch fixes this by using
dma_zalloc_coherent instead of dma_alloc_coherent.
Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit")
Signed-off-by: Yan Markman <ymarkman@marvell.com>
[Antoine: commit message]
Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
---
drivers/net/ethernet/marvell/mvpp2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c
index d83a78be98a2..fed2b2f909fc 100644
--- a/drivers/net/ethernet/marvell/mvpp2.c
+++ b/drivers/net/ethernet/marvell/mvpp2.c
@@ -5598,7 +5598,7 @@ static int mvpp2_aggr_txq_init(struct platform_device *pdev,
u32 txq_dma;
/* Allocate memory for TX descriptors */
- aggr_txq->descs = dma_alloc_coherent(&pdev->dev,
+ aggr_txq->descs = dma_zalloc_coherent(&pdev->dev,
MVPP2_AGGR_TXQ_SIZE * MVPP2_DESC_ALIGNED_SIZE,
&aggr_txq->descs_dma, GFP_KERNEL);
if (!aggr_txq->descs)
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] net: mvpp2: allocate zeroed tx descriptors
2017-11-30 9:49 [PATCH net] net: mvpp2: allocate zeroed tx descriptors Antoine Tenart
@ 2017-11-30 14:14 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-11-30 14:14 UTC (permalink / raw)
To: antoine.tenart
Cc: ymarkman, gregory.clement, thomas.petazzoni, miquel.raynal,
nadavh, mw, stefanc, netdev, linux-kernel
From: Antoine Tenart <antoine.tenart@free-electrons.com>
Date: Thu, 30 Nov 2017 10:49:46 +0100
> From: Yan Markman <ymarkman@marvell.com>
>
> Reserved and unused fields in the Tx descriptors should be 0. The PPv2
> driver doesn't clear them at run-time (for performance reasons) but
> these descriptors aren't zeroed when allocated, which can lead to
> unpredictable behaviors. This patch fixes this by using
> dma_zalloc_coherent instead of dma_alloc_coherent.
>
> Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit")
> Signed-off-by: Yan Markman <ymarkman@marvell.com>
> [Antoine: commit message]
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-30 14:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-30 9:49 [PATCH net] net: mvpp2: allocate zeroed tx descriptors Antoine Tenart
2017-11-30 14:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).