* [PATCH] atm: lanai: use setup_timer instead of init_timer
@ 2017-11-24 13:27 Colin King
2017-11-30 14:23 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2017-11-24 13:27 UTC (permalink / raw)
To: Chas Williams, linux-atm-general, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Use setup_timer function instead of initializing timer with the
function and data fields.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/atm/lanai.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/atm/lanai.c b/drivers/atm/lanai.c
index 2351dad78ff5..87e8b5dfac39 100644
--- a/drivers/atm/lanai.c
+++ b/drivers/atm/lanai.c
@@ -1790,10 +1790,8 @@ static void lanai_timed_poll(unsigned long arg)
static inline void lanai_timed_poll_start(struct lanai_dev *lanai)
{
- init_timer(&lanai->timer);
+ setup_timer(&lanai->timer, lanai_timed_poll, (unsigned long)lanai);
lanai->timer.expires = jiffies + LANAI_POLL_PERIOD;
- lanai->timer.data = (unsigned long) lanai;
- lanai->timer.function = lanai_timed_poll;
add_timer(&lanai->timer);
}
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] atm: lanai: use setup_timer instead of init_timer
2017-11-24 13:27 [PATCH] atm: lanai: use setup_timer instead of init_timer Colin King
@ 2017-11-30 14:23 ` David Miller
2017-11-30 14:30 ` Colin Ian King
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2017-11-30 14:23 UTC (permalink / raw)
To: colin.king
Cc: 3chas3, linux-atm-general, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Fri, 24 Nov 2017 13:27:12 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> Use setup_timer function instead of initializing timer with the
> function and data fields.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
setup_timer() == -ENOEXIST.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] atm: lanai: use setup_timer instead of init_timer
2017-11-30 14:23 ` David Miller
@ 2017-11-30 14:30 ` Colin Ian King
0 siblings, 0 replies; 3+ messages in thread
From: Colin Ian King @ 2017-11-30 14:30 UTC (permalink / raw)
To: David Miller
Cc: 3chas3, linux-atm-general, netdev, kernel-janitors, linux-kernel
On 30/11/17 14:23, David Miller wrote:
> From: Colin King <colin.king@canonical.com>
> Date: Fri, 24 Nov 2017 13:27:12 +0000
>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Use setup_timer function instead of initializing timer with the
>> function and data fields.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> setup_timer() == -ENOEXIST.
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Apologies. My bad.
Colin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-30 14:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-24 13:27 [PATCH] atm: lanai: use setup_timer instead of init_timer Colin King
2017-11-30 14:23 ` David Miller
2017-11-30 14:30 ` Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).