From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: fw@strlen.de, netdev@vger.kernel.org
Subject: Re: [PATCH net] tcp: remove buggy call to tcp_v6_restore_cb()
Date: Thu, 30 Nov 2017 10:22:22 -0500 (EST) [thread overview]
Message-ID: <20171130.102222.2023509661427921371.davem@davemloft.net> (raw)
In-Reply-To: <1512006237.19682.6.camel@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 29 Nov 2017 17:43:57 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> tcp_v6_send_reset() expects to receive an skb with skb->cb[] layout as
> used in TCP stack.
> MD5 lookup uses tcp_v6_iif() and tcp_v6_sdif() and thus
> TCP_SKB_CB(skb)->header.h6
>
> This patch probably fixes RST packets sent on behalf of a timewait md5
> ipv6 socket.
>
> Before Florian patch, tcp_v6_restore_cb() was needed before jumping to
> no_tcp_socket label.
>
> Fixes: 271c3b9b7bda ("tcp: honour SO_BINDTODEVICE for TW_RST case too")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2017-11-30 15:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 1:43 [PATCH net] tcp: remove buggy call to tcp_v6_restore_cb() Eric Dumazet
2017-11-30 8:14 ` Florian Westphal
2017-11-30 15:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130.102222.2023509661427921371.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).