From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] tcp: remove buggy call to tcp_v6_restore_cb()
Date: Thu, 30 Nov 2017 10:22:22 -0500 (EST)
Message-ID: <20171130.102222.2023509661427921371.davem@davemloft.net>
References: <1512006237.19682.6.camel@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: fw@strlen.de, netdev@vger.kernel.org
To: eric.dumazet@gmail.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:45774 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750742AbdK3PWY (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 30 Nov 2017 10:22:24 -0500
In-Reply-To: <1512006237.19682.6.camel@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 29 Nov 2017 17:43:57 -0800

> From: Eric Dumazet <edumazet@google.com>
> 
> tcp_v6_send_reset() expects to receive an skb with skb->cb[] layout as
> used in TCP stack.
> MD5 lookup uses tcp_v6_iif() and tcp_v6_sdif() and thus
> TCP_SKB_CB(skb)->header.h6
> 
> This patch probably fixes RST packets sent on behalf of a timewait md5
> ipv6 socket.
> 
> Before Florian patch, tcp_v6_restore_cb() was needed before jumping to
> no_tcp_socket label.
> 
> Fixes: 271c3b9b7bda ("tcp: honour SO_BINDTODEVICE for TW_RST case too")
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied and queued up for -stable.