From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH RFC 0/2] veth, bridge, and GSO maximums Date: Thu, 30 Nov 2017 09:11:30 -0800 Message-ID: <20171130091130.0400d8a5@xeon-e3> References: <20171126181749.19288-1-sthemmin@microsoft.com> <20171130.104721.823106331151241632.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, sthemmin@microsoft.com To: David Miller Return-path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:46494 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751383AbdK3RLd (ORCPT ); Thu, 30 Nov 2017 12:11:33 -0500 Received: by mail-pl0-f66.google.com with SMTP id i6so4597876plt.13 for ; Thu, 30 Nov 2017 09:11:32 -0800 (PST) In-Reply-To: <20171130.104721.823106331151241632.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 30 Nov 2017 10:47:21 -0500 (EST) David Miller wrote: > From: Stephen Hemminger > Date: Sun, 26 Nov 2017 10:17:47 -0800 > > > This pair of patchesimproves the performance when running > > containers in an environment where underlying device has lower > > GSO maximum (such as Azure). > > > > With containers a veth pair is created and one end is attached > > to the bridge device. The bridge device correctly reports > > computes GSO parameters that are the minimum of the lower devices. > > > > The problem is that the other end of the veth device (in container) > > reports the full GSO size. This patch propogates the upper > > (bridge device) parameters to the other end of the veth device. > > > > Please consider it as alternative to the sysfs GSO changes. > > I like this approach a lot, please resubmit this formally. Will do and add netif_needs_gso check as well.