From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH net-next 7/8] netdevsim: add SR-IOV functionality Date: Thu, 30 Nov 2017 14:57:36 -0800 Message-ID: <20171130145736.706c78e3@cakuba.netronome.com> References: <20171130222853.29395-1-jakub.kicinski@netronome.com> <20171130222853.29395-8-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, daniel@iogearbox.net, alexei.starovoitov@gmail.com, jiri@resnulli.us, oss-drivers@netronome.com, Phil Sutter , Sabrina Dubroca To: netdev@vger.kernel.org Return-path: Received: from mail-pg0-f52.google.com ([74.125.83.52]:40105 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751494AbdK3W5k (ORCPT ); Thu, 30 Nov 2017 17:57:40 -0500 Received: by mail-pg0-f52.google.com with SMTP id k15so3631136pgr.7 for ; Thu, 30 Nov 2017 14:57:40 -0800 (PST) In-Reply-To: <20171130222853.29395-8-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 30 Nov 2017 14:28:52 -0800, Jakub Kicinski wrote: > +static void nsim_free(struct net_device *dev) > +{ > + struct netdevsim *ns = netdev_priv(dev); > + > + device_unregister(&ns->dev); > } self-nack, I need to free the device from release handler... sorry...