From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roman Gushchin <guro@fb.com>
Subject: Re: [PATCH net-next 3/5] bpftool: implement cgattach command
Date: Thu, 30 Nov 2017 16:44:52 +0000
Message-ID: <20171130164445.GA4238@castle.DHCP.thefacebook.com>
References: <20171130134302.2840-1-guro@fb.com>
 <20171130134302.2840-4-guro@fb.com>
 <24b1be13-0f42-7695-7b06-7236b2c0beeb@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kernel-team@fb.com>, <ast@kernel.org>, <daniel@iogearbox.net>,
        <jakub.kicinski@netronome.com>, <kafai@fb.com>
To: David Ahern <dsahern@gmail.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <24b1be13-0f42-7695-7b06-7236b2c0beeb@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Thu, Nov 30, 2017 at 09:17:17AM -0700, David Ahern wrote:
> On 11/30/17 6:43 AM, Roman Gushchin wrote:
> > @@ -75,12 +80,13 @@ static int do_help(int argc, char **argv)
> >  	fprintf(stderr,
> >  		"Usage: %s [OPTIONS] OBJECT { COMMAND | help }\n"
> >  		"       %s batch file FILE\n"
> > +		"       %s cgattach FILE CGROUP TYPE\n"
> 
> Can you change the order to:
> +		"       %s cgattach CGROUP TYPE FILE\n"
> 
> Makes for better consistency with the detach command in the next patch:
> +		"       %s cgdetach CGROUP TYPE ID\n"
> 
> 

Good point.

I'll fix this and will add support for attach_flags in v2.

Thanks!