From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: [PATCH net-next 2/5] rhashtable: Add rhastable_walk_peek Date: Fri, 1 Dec 2017 12:21:02 +1100 Message-ID: <20171201012102.GA26965@gondor.apana.org.au> References: <20171201000305.2392-1-tom@quantonium.net> <20171201000305.2392-3-tom@quantonium.net> <20171201003841.GA26474@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S . Miller" , Linux Kernel Network Developers , Rohit LastName To: Tom Herbert Return-path: Received: from [128.1.224.119] ([128.1.224.119]:41578 "EHLO ringil.hmeau.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751383AbdLABVM (ORCPT ); Thu, 30 Nov 2017 20:21:12 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Nov 30, 2017 at 05:15:16PM -0800, Tom Herbert wrote: > > We don't need a guarantee of stability, but what I am seeing is that > we're consisitently dropping entries on when doing a multi-part > netlink walk. We start iterating over the table filling in the netlink > info. But eventually the netlink info fills up and returns an error. > netlink dump gets called again but now the iter of the table returns > the object following the one that would have overflowed the netlink > buffer. So the result I was seeing is that we dropped one object in in > each pass. Thanks Tom! This information is very useful. It sounds like this problem isn't specific to ila and would exist for all rhashtable users that dump through netlink. Let me think about this a little bit more. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt