From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: David Laight <David.Laight@ACULAB.COM>,
'Andrew Morton' <akpm@linux-foundation.org>,
"Tobin C. Harding" <me@tobin.cc>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Theodore Ts'o <tytso@mit.edu>, Kees Cook <keescook@chromium.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Tycho Andersen <tycho@tycho.ws>,
"Roberts, William C" <william.c.roberts@intel.com>,
Tejun Heo <tj@kernel.org>,
Jordan Glover <Golden_Miller83@protonmail.ch>,
Greg KH <gregkh@linuxfoundation.org>,
Petr Mladek <pmladek@suse.com>, Joe Perches <joe@perches.com>,
Ian Campbell <ijc@hellion.org.uk>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Catalin Marinas <c
Subject: Re: [PATCH V11 0/5] hash addresses printed with %p
Date: Fri, 1 Dec 2017 15:15:26 +0900 [thread overview]
Message-ID: <20171201061526.GA482@jagdpanzerIV> (raw)
In-Reply-To: <20171130102638.GA434@jagdpanzerIV>
On (11/30/17 19:26), Sergey Senozhatsky wrote:
> On (11/30/17 10:23), David Laight wrote:
> [..]
> > > Maybe I'm being thick, but... if we're rendering these addresses
> > > unusable by hashing them, why not just print something like
> > > "<obscured>" in their place? That loses the uniqueness thing but I
> > > wonder how valuable that is in practice?
> >
> > My worry is that is you get a kernel 'oops' print with actual register
> > values you have no easy way of tying an address or address+offset to
> > the corresponding hash(address) printed elsewhere.
>
> print the existing hash:pointer mappings in panic()? [if we can do that]
by this I meant
"when oops_in_progress == 1 then print hash:pointer for %p,
not just hash".
-ss
prev parent reply other threads:[~2017-12-01 6:15 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 2:05 [PATCH V11 0/5] hash addresses printed with %p Tobin C. Harding
2017-11-29 2:05 ` [PATCH V11 1/5] docs: correct documentation for %pK Tobin C. Harding
2017-11-29 2:05 ` [PATCH V11 2/5] vsprintf: refactor %pK code out of pointer() Tobin C. Harding
2017-11-29 2:39 ` Steven Rostedt
2017-11-29 4:27 ` Tobin C. Harding
2017-11-29 11:54 ` Steven Rostedt
2017-11-29 2:05 ` [PATCH V11 3/5] printk: hash addresses printed with %p Tobin C. Harding
2017-11-29 23:21 ` Andrew Morton
2017-12-05 20:20 ` Geert Uytterhoeven
2017-12-05 20:31 ` David Miller
2017-12-06 10:31 ` David Laight
2017-12-06 23:21 ` Kees Cook
2017-12-06 23:28 ` Linus Torvalds
2017-12-05 20:44 ` Tobin C. Harding
2017-12-05 22:57 ` Geert Uytterhoeven
2017-12-05 23:33 ` Linus Torvalds
2017-12-06 8:48 ` Geert Uytterhoeven
2017-11-29 2:05 ` [PATCH V11 4/5] vsprintf: add printk specifier %px Tobin C. Harding
2017-11-29 2:29 ` Linus Torvalds
2017-11-29 4:29 ` Tobin C. Harding
2017-11-29 10:07 ` David Laight
2017-11-29 22:28 ` Kees Cook
2017-11-29 22:36 ` Roberts, William C
2017-11-29 22:47 ` Linus Torvalds
2017-11-30 10:38 ` David Laight
2017-12-05 21:08 ` Randy Dunlap
2017-12-05 21:22 ` Linus Torvalds
2017-12-06 1:36 ` Sergey Senozhatsky
2017-12-06 1:59 ` Linus Torvalds
2017-12-06 2:15 ` Sergey Senozhatsky
2017-12-06 8:32 ` Geert Uytterhoeven
2017-12-06 8:45 ` Sergey Senozhatsky
2017-12-07 5:17 ` Tobin C. Harding
2017-12-07 5:29 ` Linus Torvalds
2017-12-07 5:37 ` Sergey Senozhatsky
2017-12-07 5:12 ` Tobin C. Harding
2017-11-29 23:20 ` Andrew Morton
2017-11-29 23:26 ` Tobin C. Harding
2017-11-30 3:58 ` Joe Perches
2017-11-30 4:18 ` Tobin C. Harding
2017-11-30 4:41 ` Joe Perches
2017-11-30 5:00 ` Tobin C. Harding
2017-11-29 2:05 ` [PATCH V11 5/5] kasan: use %px to print addresses instead of %p Tobin C. Harding
2017-11-29 23:20 ` [PATCH V11 0/5] hash addresses printed with %p Andrew Morton
2017-11-29 23:34 ` Tobin C. Harding
2017-11-30 10:23 ` David Laight
2017-11-30 10:26 ` Sergey Senozhatsky
2017-12-01 6:15 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201061526.GA482@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=Golden_Miller83@protonmail.ch \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc@hellion.org.uk \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=me@tobin.cc \
--cc=pbonzini@redhat.com \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tycho@tycho.ws \
--cc=tytso@mit.edu \
--cc=william.c.roberts@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).