From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Senozhatsky Subject: Re: [PATCH V11 0/5] hash addresses printed with %p Date: Fri, 1 Dec 2017 15:15:26 +0900 Message-ID: <20171201061526.GA482@jagdpanzerIV> References: <1511921105-3647-1-git-send-email-me@tobin.cc> <20171129152040.ed5b28c198093de8968aac9b@linux-foundation.org> <28ab447e24684c58a5e03af44edd6d5a@AcuMS.aculab.com> <20171130102638.GA434@jagdpanzerIV> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Laight , 'Andrew Morton' , "Tobin C. Harding" , "kernel-hardening@lists.openwall.com" , Linus Torvalds , "Jason A. Donenfeld" , Theodore Ts'o , Kees Cook , Paolo Bonzini , Tycho Andersen , "Roberts, William C" , Tejun Heo , Jordan Glover , Greg KH , Petr Mladek , Joe Perches , Ian Campbell , Sergey Senozhatsky , Catalin Marinas Return-path: Received: from mail-pf0-f181.google.com ([209.85.192.181]:44301 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988AbdLAGPc (ORCPT ); Fri, 1 Dec 2017 01:15:32 -0500 Content-Disposition: inline In-Reply-To: <20171130102638.GA434@jagdpanzerIV> Sender: netdev-owner@vger.kernel.org List-ID: On (11/30/17 19:26), Sergey Senozhatsky wrote: > On (11/30/17 10:23), David Laight wrote: > [..] > > > Maybe I'm being thick, but... if we're rendering these addresses > > > unusable by hashing them, why not just print something like > > > "" in their place? That loses the uniqueness thing but I > > > wonder how valuable that is in practice? > > > > My worry is that is you get a kernel 'oops' print with actual register > > values you have no easy way of tying an address or address+offset to > > the corresponding hash(address) printed elsewhere. > > print the existing hash:pointer mappings in panic()? [if we can do that] by this I meant "when oops_in_progress == 1 then print hash:pointer for %p, not just hash". -ss