From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2] iproute2: Fix undeclared __kernel_long_t type build error in RHEL 6.8 Date: Fri, 1 Dec 2017 08:48:07 -0800 Message-ID: <20171201084807.0ccfcc86@xeon-e3> References: <20171201110451.25392-1-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, Leon Romanovsky , Riad Abo Raed , Guy Ergas To: Leon Romanovsky Return-path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:34582 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750994AbdLAQsS (ORCPT ); Fri, 1 Dec 2017 11:48:18 -0500 Received: by mail-pf0-f195.google.com with SMTP id a90so4887788pfk.1 for ; Fri, 01 Dec 2017 08:48:18 -0800 (PST) In-Reply-To: <20171201110451.25392-1-leon@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 1 Dec 2017 13:04:51 +0200 Leon Romanovsky wrote: > From: Leon Romanovsky >=20 > Add asm/posix_types.h header file to the list of needed includes, > because the headers files in RHEL 6.8 are too old and doesn't > have declaration of __kernel_long_t. >=20 > In file included from ../include/uapi/linux/kernel.h:5, > from ../include/uapi/linux/netfilter/x_tables.h:4, > from ../include/xtables.h:20, > from em_ipset.c:26: > ../include/uapi/linux/sysinfo.h:9: error: expected specifier-qualifier-li= st before =E2=80=98__kernel_long_t=E2=80=99 >=20 > Cc: Riad Abo Raed > Cc: Guy Ergas > Signed-off-by: Leon Romanovsky I see the problem, but the solution of dragging in posix_types.h would be too much of a long term maintenance issue. All the headers in uapi are regularly generated from upstream kernel headers; I don't want to start making exceptions. Is it just the xtables stuff (which has always been problematic)?