From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 1/3] vhost: fix skb leak in handle_rx()
Date: Fri, 1 Dec 2017 16:37:43 +0200
Message-ID: <20171201163728-mutt-send-email-mst@kernel.org>
References: <1512107669-27572-1-git-send-email-wexu@redhat.com>
	<1512107669-27572-2-git-send-email-wexu@redhat.com>
	<09e75683-4c49-7446-e13e-93b316ed270c@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Cc: mjrosato@linux.vnet.ibm.com, netdev@vger.kernel.org, wexu@redhat.com,
	linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org
To: Jason Wang <jasowang@redhat.com>
Return-path: <virtualization-bounces@lists.linux-foundation.org>
Content-Disposition: inline
In-Reply-To: <09e75683-4c49-7446-e13e-93b316ed270c@redhat.com>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/virtualization/>
List-Post: <mailto:virtualization@lists.linux-foundation.org>
List-Help: <mailto:virtualization-request@lists.linux-foundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=subscribe>
Sender: virtualization-bounces@lists.linux-foundation.org
Errors-To: virtualization-bounces@lists.linux-foundation.org
List-Id: netdev.vger.kernel.org

T24gRnJpLCBEZWMgMDEsIDIwMTcgYXQgMDM6MTE6MDVQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90
ZToKPiAKPiAKPiBPbiAyMDE35bm0MTLmnIgwMeaXpSAxMzo1NCwgd2V4dUByZWRoYXQuY29tIHdy
b3RlOgo+ID4gRnJvbTogV2VpIFh1IDx3ZXh1QHJlZGhhdC5jb20+Cj4gPiAKPiA+IE1hdHRoZXcg
Zm91bmQgYSByb3VnaGx5IDQwJSB0Y3AgdGhyb3VnaHB1dCByZWdyZXNzaW9uIHdpdGggY29tbWl0
Cj4gPiBjNjdkZjExZih2aG9zdF9uZXQ6IHRyeSBiYXRjaCBkZXF1aW5nIGZyb20gc2tiIGFycmF5
KSBhcyBkaXNjdXNzZWQKPiA+IGluIHRoZSBmb2xsb3dpbmcgdGhyZWFkOgo+ID4gaHR0cHM6Ly93
d3cubWFpbC1hcmNoaXZlLmNvbS9uZXRkZXZAdmdlci5rZXJuZWwub3JnL21zZzE4NzkzNi5odG1s
Cj4gPiAKPiA+IEV2ZW50dWFsbHkgd2UgZmlndXJlZCBvdXQgdGhhdCBpdCB3YXMgYSBza2IgbGVh
ayBpbiBoYW5kbGVfcngoKQo+ID4gd2hlbiBzZW5kaW5nIHBhY2tldHMgdG8gdGhlIFZNLiBUaGlz
IHVzdWFsbHkgaGFwcGVucyB3aGVuIGEgZ3Vlc3QKPiA+IGNhbiBub3QgZHJhaW4gb3V0IHZxIGFz
IGZhc3QgYXMgdmhvc3QgZmlsbHMgaW4sIGFmdGVyd2FyZHMgaXQgc2V0cwo+ID4gb2ZmIHRoZSB0
cmFmZmljIGphbSBhbmQgbGVha3Mgc2tiKHMpIHdoaWNoIG9jY3VycyBhcyBubyBoZWFkY291bnQK
PiA+IHRvIHNlbmQgb24gdGhlIHZxIGZyb20gdmhvc3Qgc2lkZS4KPiA+IAo+ID4gVGhpcyBjYW4g
YmUgYXZvaWRlZCBieSBtYWtpbmcgc3VyZSB3ZSBoYXZlIGdvdCBlbm91Z2ggaGVhZGNvdW50Cj4g
PiBiZWZvcmUgYWN0dWFsbHkgY29uc3VtaW5nIGEgc2tiIGZyb20gdGhlIGJhdGNoZWQgcnggYXJy
YXkgd2hpbGUKPiA+IHRyYW5zbWl0dGluZywgd2hpY2ggaXMgc2ltcGx5IGRvbmUgYnkgbW92aW5n
IGNoZWNraW5nIHRoZSB6ZXJvCj4gPiBoZWFkY291bnQgYSBiaXQgYWhlYWQuCj4gPiAKPiA+IFNp
Z25lZC1vZmYtYnk6IFdlaSBYdSA8d2V4dUByZWRoYXQuY29tPgo+ID4gUmVwb3J0ZWQtYnk6IE1h
dHRoZXcgUm9zYXRvIDxtanJvc2F0b0BsaW51eC52bmV0LmlibS5jb20+Cj4gPiAtLS0KPiA+ICAg
ZHJpdmVycy92aG9zdC9uZXQuYyB8IDIwICsrKysrKysrKystLS0tLS0tLS0tCj4gPiAgIDEgZmls
ZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvdmhvc3QvbmV0LmMgYi9kcml2ZXJzL3Zob3N0L25ldC5jCj4gPiBp
bmRleCA4ZDYyNmQ3Li5jN2JkZWI2IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy92aG9zdC9uZXQu
Ywo+ID4gKysrIGIvZHJpdmVycy92aG9zdC9uZXQuYwo+ID4gQEAgLTc3OCwxNiArNzc4LDYgQEAg
c3RhdGljIHZvaWQgaGFuZGxlX3J4KHN0cnVjdCB2aG9zdF9uZXQgKm5ldCkKPiA+ICAgCQkvKiBP
biBlcnJvciwgc3RvcCBoYW5kbGluZyB1bnRpbCB0aGUgbmV4dCBraWNrLiAqLwo+ID4gICAJCWlm
ICh1bmxpa2VseShoZWFkY291bnQgPCAwKSkKPiA+ICAgCQkJZ290byBvdXQ7Cj4gPiAtCQlpZiAo
bnZxLT5yeF9hcnJheSkKPiA+IC0JCQltc2cubXNnX2NvbnRyb2wgPSB2aG9zdF9uZXRfYnVmX2Nv
bnN1bWUoJm52cS0+cnhxKTsKPiA+IC0JCS8qIE9uIG92ZXJydW4sIHRydW5jYXRlIGFuZCBkaXNj
YXJkICovCj4gPiAtCQlpZiAodW5saWtlbHkoaGVhZGNvdW50ID4gVUlPX01BWElPVikpIHsKPiA+
IC0JCQlpb3ZfaXRlcl9pbml0KCZtc2cubXNnX2l0ZXIsIFJFQUQsIHZxLT5pb3YsIDEsIDEpOwo+
ID4gLQkJCWVyciA9IHNvY2stPm9wcy0+cmVjdm1zZyhzb2NrLCAmbXNnLAo+ID4gLQkJCQkJCSAx
LCBNU0dfRE9OVFdBSVQgfCBNU0dfVFJVTkMpOwo+ID4gLQkJCXByX2RlYnVnKCJEaXNjYXJkZWQg
cnggcGFja2V0OiBsZW4gJXpkXG4iLCBzb2NrX2xlbik7Cj4gPiAtCQkJY29udGludWU7Cj4gPiAt
CQl9Cj4gPiAgIAkJLyogT0ssIG5vdyB3ZSBuZWVkIHRvIGtub3cgYWJvdXQgYWRkZWQgZGVzY3Jp
cHRvcnMuICovCj4gPiAgIAkJaWYgKCFoZWFkY291bnQpIHsKPiA+ICAgCQkJaWYgKHVubGlrZWx5
KHZob3N0X2VuYWJsZV9ub3RpZnkoJm5ldC0+ZGV2LCB2cSkpKSB7Cj4gPiBAQCAtODAwLDYgKzc5
MCwxNiBAQCBzdGF0aWMgdm9pZCBoYW5kbGVfcngoc3RydWN0IHZob3N0X25ldCAqbmV0KQo+ID4g
ICAJCQkgKiB0aGV5IHJlZmlsbGVkLiAqLwo+ID4gICAJCQlnb3RvIG91dDsKPiA+ICAgCQl9Cj4g
PiArCQlpZiAobnZxLT5yeF9hcnJheSkKPiA+ICsJCQltc2cubXNnX2NvbnRyb2wgPSB2aG9zdF9u
ZXRfYnVmX2NvbnN1bWUoJm52cS0+cnhxKTsKPiA+ICsJCS8qIE9uIG92ZXJydW4sIHRydW5jYXRl
IGFuZCBkaXNjYXJkICovCj4gPiArCQlpZiAodW5saWtlbHkoaGVhZGNvdW50ID4gVUlPX01BWElP
VikpIHsKPiA+ICsJCQlpb3ZfaXRlcl9pbml0KCZtc2cubXNnX2l0ZXIsIFJFQUQsIHZxLT5pb3Ys
IDEsIDEpOwo+ID4gKwkJCWVyciA9IHNvY2stPm9wcy0+cmVjdm1zZyhzb2NrLCAmbXNnLAo+ID4g
KwkJCQkJCSAxLCBNU0dfRE9OVFdBSVQgfCBNU0dfVFJVTkMpOwo+ID4gKwkJCXByX2RlYnVnKCJE
aXNjYXJkZWQgcnggcGFja2V0OiBsZW4gJXpkXG4iLCBzb2NrX2xlbik7Cj4gPiArCQkJY29udGlu
dWU7Cj4gPiArCQl9Cj4gPiAgIAkJLyogV2UgZG9uJ3QgbmVlZCB0byBiZSBub3RpZmllZCBhZ2Fp
bi4gKi8KPiA+ICAgCQlpb3ZfaXRlcl9pbml0KCZtc2cubXNnX2l0ZXIsIFJFQUQsIHZxLT5pb3Ys
IGluLCB2aG9zdF9sZW4pOwo+ID4gICAJCWZpeHVwID0gbXNnLm1zZ19pdGVyOwo+IAo+IEkgc3Vn
Z2VzdCB0byByZW9yZGVyIHRoaXMgcGF0Y2ggdG8gMy8zLgo+IAo+IFRoYW5rcwoKV2h5PyBUaGlz
IGRvZXNuJ3QgY2F1c2UgYW55IG5ldyBsZWFrcywgZG9lcyBpdD8KCi0tIApNU1QKX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFp
bGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBz
Oi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0
aW9u